Codecov Report

Merging #1210 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1210      +/-   ##
==========================================
+ Coverage   92.34%   92.36%   +0.01%     
==========================================
  Files          54       54              
  Lines        5294     5307      +13     
  Branches     1191     1195       +4     
==========================================
+ Hits         4889     4902      +13     
  Misses        405      405              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8afd4c...108a5aa. Read the comment docs.

@mtrezza How does this look? Is this an accurate way to test idempotency?

Wow, I had this on my list for next month but you overtook me there 👏
Let me take a look at it later today.

Does the JS SDK have an automated request retry mechanism like the iOS and Android SDKs? If so, I think a test case makes sense that ensures that the UUID does not change on request retry. That may then also require additional logic in the REST controller to ensure that the UUID does not change.

I've looked into the Parse JS SDK and it seems that it does not have an auto-retry mechanism on failed requests, nor does XHR. For future reference: If such a mechanism ever gets implemented, similar to how it exists in the iOS and Android SDKs, this test case will likely need to be adapted to properly test that the UUID does not change.

@mtrezza I've added additional test. There is an auto-retry strategy in the SDK (in RESTController.js) I added a fix for that also. This is ready for review

Great, I will take a look later today.

@mtrezza @davimacedo How does this look?

@mtrezza I didn’t want to open a new issue, I’m writing documentation for this. How would you catch a duplicate request error?

try {
  await Parse.Cloud.run('duplicate')
  // code here would run for the first request
} catch(e) {
 // duplicate request here
}

@dplewis Yes, in addition the catch block would check for ParseError.DUPLICATE_REQUEST 159, see https://github.com/parse-community/Parse-SDK-JS/pull/1189/files.

The comment is not correct in all cases, it could "run for the first time" but end up in the catch block for another reason than duplicate request. So you could add "runs for first time and succeeds" in try block and in the catch block "runs for first times and failed" if error code is not 159, and "runs multiple times as duplicate requests" if error code is 159.

Can you think of a way to replicate a duplicate request in a test environment?

try {
  const value = await Parse.Cloud.run('duplicate');
  // do something with value
} catch(e) {
  if (e.code === Parse.Error.DUPLICATE_REQUEST) {
   // duplicate request here
  }
  // handle other errors
}

Edit: I can just create a custom RESTController

Sure, just send an identical request ID in the header and the request should fail as duplicate request. To send an identical request ID you could spyOn the request ID and fake it to make it the same in every request. If you look at the existing test cases for idempotency, they show exactly that. Let me know if you need more details, then I'll look into the JS SDK.

The tests cases are good, I was referring to a real environment. Website, press a button and send a duplicate request.
I just copied the RESTController, set a static requestId and CoreManager.setRESTController.

I was referring to a real environment. Website, press a button and send a duplicate request.

You mean as an example description in the docs or as a real coded test? I think I understand now, you mean testing this in a real environment, outside of this repo. Well, yes, you could set up a firewall with a rule that allows only requests client --> server and blocks responses client <-- server. The JS SDK (if it has a retry mechanism?) would retry a request after a timeout because it didn't receive an answer and the server would then respond with duplicate request. Note that is has to be a POST or PUT request.